omeka-s icon indicating copy to clipboard operation
omeka-s copied to clipboard

Assets table width

Open allanaaa opened this issue 2 years ago • 4 comments

I uploaded an 1800x100 pixel banner and it's doing something untoward in the Assets table:

asset-width

It looks like .asset-entry img has max-heights but not max-widths. My command of flexbox is rusty but I think you could squish the image if there's a long filename, but not squish the filename or overflow the box if there's a wide image. Somehow....

allanaaa avatar Oct 11 '22 19:10 allanaaa

A fix is ready for testing.

kimisgold avatar Feb 08 '23 21:02 kimisgold

This is fine. I don't love the max-width:50% on the images, I feel like squishing them even shorter than 48px is a bit of a waste of space. But it's an improvement for sure. assets

allanaaa avatar Feb 09 '23 17:02 allanaaa

Hmm, I'm not sure I'm understanding your comment. How do you think space is wasted and did you have an alternative solution in mind?

kimisgold avatar Feb 09 '23 18:02 kimisgold

For the really wide assets that still have lots of space left in their rows - mapbanner.jpg etc. - they're being compressed down to a point where you can't see much detail. I guess I would prefer something more of a compromise like this:

assets

But my CSS & flex are rusty so I may not be doing this the best way. Here's what it looks like: assets

I turned off the max-width and put overflow:hidden on the .asset-entry img (not at all sure why that's working...), and put max-width:calc(100% - 72px) on the .asset-entry, to always leave space for the "actions" buttons.

allanaaa avatar Feb 09 '23 19:02 allanaaa