omeka-s icon indicating copy to clipboard operation
omeka-s copied to clipboard

Published 20 hours ago • verified publisher icon omeka

Enables 'copy' icon.

Open fukuchi opened this issue 3 years ago • 3 comments

This patch enables font-awesome's 'copy' icon. Copy icon is useful for a variety of purposes: this will help module developers.

This patch is a purified version of cc300f468b2661cf7d06dce4faf2575a2733c34d of #1501.

fukuchi avatar Aug 22 '21 12:08 fukuchi

Here's a typical use-case of the copy icon: Screenshot from 2021-08-23 11-58-33

fukuchi avatar Aug 23 '21 03:08 fukuchi

I have a concern with this PR: I'm not sure we want to be providing these "o-icon" aliases for icons we're not actually using.

Modules can of course use any of the FA icons without having this provided in the core's styles just by using the proper content styles.

@kimisgold : thoughts?

zerocrates avatar Nov 03 '21 19:11 zerocrates

@zerocrates,

Thank you for your interest in this pull request. Originally, this PR was part of #1501 and #1503. The simplest way to implement the copy action in Omeka S was to modify Omeka S itself, so I implemented it and submitted the pull requests instead of developing plugins.

That's why I suggested adding copy icon.

fukuchi avatar Nov 05 '21 13:11 fukuchi