omegat icon indicating copy to clipboard operation
omegat copied to clipboard

Published 20 hours ago • verified publisher icon omegat-org

[BUGS#1248,1251] add regression test and refactor FindMatches class

Open miurahr opened this issue 1 year ago • 5 comments

Pull request type

Please mark github LABEL of the type of change your PR introduces:

  • Bug fix -> [bug]

Which ticket is resolved?

  • tm/penalty-nnn value is not respected

  • https://sourceforge.net/p/omegat/bugs/1248/

  • FindMatcher always search separate segment match without penalty

  • https://sourceforge.net/p/omegat/bugs/1251/

What does this PR change?

  • Add regression test for BUGS#1248 and 1251 against both FindMatches and FindMatchesThread classes, that is failed by the bug reported.
  • Split FindMatches#search method to searchNormal and searchSegmented, and remove boolean allowSeparateSegmentMatch argument from constructor.
  • Refactor FindMatchesThread#search to call searchNormal then searchSegmented if necessary.
  • searchSEgmented method skips external TMs.

Other information

miurahr avatar Feb 17 '24 00:02 miurahr

❌ Run Gradle test failed:

github-actions[bot] avatar Feb 17 '24 04:02 github-actions[bot]

❌ Run Gradle test failed:

github-actions[bot] avatar Feb 17 '24 06:02 github-actions[bot]

❌ Run Gradle test failed:

github-actions[bot] avatar Feb 17 '24 06:02 github-actions[bot]

A topic branch here waiting a realization of GUI behavior acceptance test #964 is accepted.

miurahr avatar Mar 09 '24 02:03 miurahr

A topic branch here waiting a realization of GUI behavior acceptance test #964 is accepted.

GUI testing is not stable to be integrated. So we should merge it now.

miurahr avatar Aug 14 '24 12:08 miurahr