omegat icon indicating copy to clipboard operation
omegat copied to clipboard

WIP: refactor: modular filters

Open miurahr opened this issue 1 year ago • 7 comments

This is topic development branch to demonstrate how filters can be modules.

Pull request type

  • Other (describe below) refactor

Which ticket is resolved?

What does this PR change?

  • All of #931 changes
  • Split filters into three modules, filters2, staxfilters (from filters4) and xmlfilters (from filters3).
  • Refactor tests into each modules.

Other information

miurahr avatar Jan 26 '24 00:01 miurahr

❌ Run Gradle test failed:

github-actions[bot] avatar Jan 26 '24 01:01 github-actions[bot]

❌ Run Gradle test failed:

github-actions[bot] avatar Jan 27 '24 05:01 github-actions[bot]

Now modularization of filters have been almost done.

What I have done is...

  • Change all filters to be OmegaT 3.1 interface that have loadPlugin method.
  • Refactor source and test code under sub project, filters2 and xmlfilters
  • xmlfilters project has filters3 and filters4 filters
  • Move test data under <subproject>/src/test/resources/
  • Put .gitattributes for some test data which EoL is important
  • Introduce testFixtures stub filters that are used in core test codes, which requires htmlparser and jackson dependency.
  • Tweak dependency for filters. remove stax and PDF library from core and put in filters sub project
  • Update checkstyle suppression configuration
  • Update test cases to point new path of test data

miurahr avatar Jan 27 '24 07:01 miurahr

❌ Run Gradle test failed:

github-actions[bot] avatar Jan 27 '24 22:01 github-actions[bot]

❌ Run Gradle test failed:

github-actions[bot] avatar Jan 27 '24 23:01 github-actions[bot]

❌ Run Gradle test failed:

github-actions[bot] avatar Jan 27 '24 23:01 github-actions[bot]

❌ Run Gradle test failed:

github-actions[bot] avatar Jan 28 '24 00:01 github-actions[bot]