omegat icon indicating copy to clipboard operation
omegat copied to clipboard

feat: StaX filter produce self-contained empty element

Open miurahr opened this issue 1 year ago • 4 comments

Set Woodstox property to allow self-contained empty element in StaX filters

Pull request type

  • Feature enhancement -> [enhancement]

Which ticket is resolved?

What does this PR change?

Other information

miurahr avatar Oct 22 '23 02:10 miurahr

The idea is good but we must check what DOCX format requires. Even if in theory <x></x> and <x/> are strictly equivalent it sometimes happens that some tools (like Word, or Trados!) do not consider as such. I must do some tests before to validate it (even if strictly speaking I approve)

t-cordonnier avatar Oct 22 '23 06:10 t-cordonnier

@t-cordonnier yes or no?

miurahr avatar Nov 05 '23 12:11 miurahr

progress?

miurahr avatar Nov 18 '23 11:11 miurahr

I found an example where a document containing something like <x></x> was rejected by Trados Studio while accepted by Word. So in principle I would say yes, in theory. But considering that in theory the just mentioned error should not happen, I prefer concrete tests than abstract theory. So, before validating, are you capable of giving me an example where OmegaT produces a different document after your patch than before? If yes, I will test the document against various tools and tell you wherever your change improves compatibility or can make a regression.

t-cordonnier avatar Nov 20 '23 15:11 t-cordonnier