pfcpsim icon indicating copy to clipboard operation
pfcpsim copied to clipboard

Enable `revive` linter

Open gab-arrobo opened this issue 1 year ago • 3 comments

With the goal of improving the code quality in this repo, it would be good to add the revive linter (as shown below) and properly add the documentation to the different functions

diff --git a/.golangci.yml b/.golangci.yml
index 357611a..4d11a06 100644
--- a/.golangci.yml
+++ b/.golangci.yml
@@ -239,6 +239,7 @@ linters:
     - typecheck
     # Additional
     # - lll
+    - revive
     - godox
     #- gomnd
     - goconst

gab-arrobo avatar May 30 '24 19:05 gab-arrobo

@ianchen0119 are you or someone you know available to help address this issue?

gab-arrobo avatar May 30 '24 19:05 gab-arrobo

Hi @gab-arrobo Would you happen to know if this task is urgent? if not, I can help.

ianchen0119 avatar May 31 '24 02:05 ianchen0119

Hi @gab-arrobo Would you happen to know if this task is urgent? if not, I can help.

Hi @ianchen0119, This is not an urgent task. Please feel free to work on it when you have a chance. After this is addressed, I can create a new tag/release for pfcpsim, Thanks!

gab-arrobo avatar May 31 '24 03:05 gab-arrobo