ome-zarr-py icon indicating copy to clipboard operation
ome-zarr-py copied to clipboard

Support init of ome_zarr_py.io.ZarrLocation with zarr.storage.FSStore

Open berombau opened this issue 2 years ago • 3 comments

By supporting FSStore as input, more complex ZarrLocations are possible like private remote stores.

berombau avatar Jan 26 '24 12:01 berombau

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 85.36%. Comparing base (f79bad0) to head (6d718e0).

:exclamation: Current head 6d718e0 differs from pull request most recent head 03d8f53. Consider uploading reports for the commit 03d8f53 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #349      +/-   ##
==========================================
+ Coverage   85.06%   85.36%   +0.30%     
==========================================
  Files          13       13              
  Lines        1533     1531       -2     
==========================================
+ Hits         1304     1307       +3     
+ Misses        229      224       -5     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Jan 26 '24 12:01 codecov[bot]

Thanks, @berombau. Would you be up for adding a test that makes use of this?

joshmoore avatar Jan 31 '24 08:01 joshmoore

@joshmoore Sure, I added some basic tests. More bespoke testing would require a dependency on s3fs or universal_pathlib, but this covers my use case.

berombau avatar Jan 31 '24 15:01 berombau

This PR would solve #369 for bioio-ome-zarr. What needs to happen to get this change merged?

pgarrison avatar Apr 17 '24 19:04 pgarrison

It's ready to go in the next release, I think. I worked with universal-pathlib and moto in a spatialdata fork and it works well, but it's better to work on that if needed in a separate PR.

berombau avatar Apr 22 '24 07:04 berombau

Thanks, all! Due to the change of the API, going to release this now as 0.9.0. @pgarrison, interested to hear if it solves all your troubles. 🙂

joshmoore avatar May 22 '24 08:05 joshmoore

@joshmoore yes I was able to use this pattern to read a public s3:// path without authentication, thanks all!

pgarrison avatar Jul 17 '24 23:07 pgarrison