Support init of ome_zarr_py.io.ZarrLocation with zarr.storage.FSStore
By supporting FSStore as input, more complex ZarrLocations are possible like private remote stores.
Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 85.36%. Comparing base (
f79bad0) to head (6d718e0).
:exclamation: Current head 6d718e0 differs from pull request most recent head 03d8f53. Consider uploading reports for the commit 03d8f53 to get more accurate results
Additional details and impacted files
@@ Coverage Diff @@
## master #349 +/- ##
==========================================
+ Coverage 85.06% 85.36% +0.30%
==========================================
Files 13 13
Lines 1533 1531 -2
==========================================
+ Hits 1304 1307 +3
+ Misses 229 224 -5
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Thanks, @berombau. Would you be up for adding a test that makes use of this?
@joshmoore Sure, I added some basic tests. More bespoke testing would require a dependency on s3fs or universal_pathlib, but this covers my use case.
This PR would solve #369 for bioio-ome-zarr. What needs to happen to get this change merged?
It's ready to go in the next release, I think. I worked with universal-pathlib and moto in a spatialdata fork and it works well, but it's better to work on that if needed in a separate PR.
Thanks, all! Due to the change of the API, going to release this now as 0.9.0. @pgarrison, interested to hear if it solves all your troubles. 🙂
@joshmoore yes I was able to use this pattern to read a public s3:// path without authentication, thanks all!