ome-zarr-py icon indicating copy to clipboard operation
ome-zarr-py copied to clipboard

Isn't `version` a `str`?

Open DimitriPapadopoulos opened this issue 10 months ago • 2 comments

In the following code, the type hint for version is str. Yet, the code has been modified to handle floats too (#189).

Should the type hint be changed from str to str | float?

https://github.com/ome/ome-zarr-py/blob/6a1de2a0924e821fecec7ac3ba8790c0a3ae234f/ome_zarr/format.py#L12-L16

DimitriPapadopoulos avatar Sep 28 '23 19:09 DimitriPapadopoulos