bioformats icon indicating copy to clipboard operation
bioformats copied to clipboard

Published 20 hours ago • verified publisher icon ome

Dead store to local variable

Open scuniff opened this issue 5 months ago • 0 comments

https://github.com/ome/bioformats/blob/682bc7e318b88f159d3c6e2603fb82fb9d613268/components/formats-bsd/src/loci/formats/dicom/DicomTag.java#L353

location is an argument to this constructor and so it being incremented won’t be seen outside this constructor. location getting updated doesn't seem to be used anywhere else in the constructor.

Was a member variable wanted??

Is location really not needed after the constructor?

scuniff avatar Sep 09 '24 20:09 scuniff