bioformats icon indicating copy to clipboard operation
bioformats copied to clipboard

DICOM: use FrameTimePointer to detect timelapse data

Open melissalinkert opened this issue 1 year ago • 4 comments

This is a potential replacement for #4167. As recommended in https://github.com/ome/bioformats/pull/4167#issuecomment-2020196397, this uses the presence of a valid FrameTimePointer to determine if SizeT should be set instead of SizeZ.

This changes the behavior of a few existing sample files, so a configuration PR is forthcoming.

melissalinkert avatar Jun 11 '24 18:06 melissalinkert

Conflicting PR. Removed from build BIOFORMATS-push#161. See the console output for more details. Possible conflicts:

  • PR #4190 melissalinkert 'Extend precompressed support to read DICOM and write TIFF/OME-TIFF'
    • components/formats-bsd/src/loci/formats/in/DicomReader.java

--conflicts

snoopycrimecop avatar Aug 10 '24 00:08 snoopycrimecop

Some test failures that look to be due to this being excluded: https://merge-ci.openmicroscopy.org/jenkins/job/BIOFORMATS-test-folder/lastFailedBuild/consoleFull

Excluding the config PR temporarily until this is back in the merge build will likely be enough to resolve the failures

dgault avatar Aug 12 '24 08:08 dgault

Conflicting PR. Removed from build BIOFORMATS-push#164. See the console output for more details. Possible conflicts:

  • PR #4190 melissalinkert 'Extend precompressed support to read DICOM and write TIFF/OME-TIFF'
    • components/formats-bsd/src/loci/formats/in/DicomReader.java

--conflicts

snoopycrimecop avatar Aug 13 '24 00:08 snoopycrimecop

Conflicting PR. Removed from build BIOFORMATS-push#165. See the console output for more details. Possible conflicts:

  • PR #4190 melissalinkert 'Extend precompressed support to read DICOM and write TIFF/OME-TIFF'
    • components/formats-bsd/src/loci/formats/in/DicomReader.java

--conflicts

snoopycrimecop avatar Aug 14 '24 00:08 snoopycrimecop

Closing, as this needs more work than I will have time for in the near future. Can always re-open later if appropriate.

melissalinkert avatar Jan 13 '25 15:01 melissalinkert