bioformats icon indicating copy to clipboard operation
bioformats copied to clipboard

matlab/bfGetPlane.m: avoid use of makeDataArray2D when Octave (ome/bio-formats-octave-docker#29)

Open carandraug opened this issue 2 years ago • 3 comments

This fixes ome/bio-formats-octave-docker#29

Octave does not autobox multi-dimensional arrays (Matlab does) so makeDataArray2D can't be used in Octave. this commit makes use of makeDataArray to get a 1D array and then reshapes it. This commit partially reverts 3aa468e9 (see ome/bioformats#3301) for Octave only. the data copy that that commit was meant to prevent is back but is limited to Octave.

For reference, the issue of Octave not autoboxing ND Java arrays is Octave bug #58745 (the issue description references a function java2mat that in theory should make this conversion but that function never worked for me and newer Octave functions have marked it somewhat internal by renaming it __java2mat__).

carandraug avatar Dec 13 '23 13:12 carandraug

Thank you @carandraug for opening the PR and the continued support for the the project. Since your previous contributions we have introduced a Contributor License Agreement for the project, would you be able to sign and return the form following the instructions on https://ome-contributing.readthedocs.io/en/latest/cla.html

dgault avatar Dec 13 '23 13:12 dgault

I'm not willing to that CLA at the moment. If you prefer, this patch is too trivial and I do not claim copyright for it.

carandraug avatar Dec 13 '23 14:12 carandraug

I've reached out separately to David P. to discuss this and his other contributions.

joshmoore avatar Jun 10 '24 13:06 joshmoore