bioformats icon indicating copy to clipboard operation
bioformats copied to clipboard

VirtualImagePlus: retain contrast in setSlice

Open tfarago opened this issue 2 years ago • 3 comments

Problem

When one loads a virtual image stack and changes the contrast by e.g. the contrast dialog, the changes are lost when the stack is scrolled, which makes it very inconvenient to look at sequences which need contrast adjustment. In classical ImageJ the contrast is retained. I noticed this behavior with 16 and 32 bit bigtiff files but assume it happens for other file formats as well.

This issue has been mentioned also in forum.image.sc.

Solution

If one comments these lines, all works as expected. The problem seems to be in the fact that proc.getChild()'s min and max values do not reflect the set display range, so when it is used in setProcessor it is lost.

tfarago avatar Jul 21 '22 13:07 tfarago

Thanks, @tfarago. Triggered the GHA workflows.

joshmoore avatar Jul 21 '22 13:07 joshmoore

Great, thanks! I will arrange for the CLA to be signed and let you know.

tfarago avatar Jul 27 '22 15:07 tfarago

Turns out it will take a while. I will be back at work 22.08., sort it out and get in touch after that. Sorry for the delay...

tfarago avatar Jul 29 '22 18:07 tfarago

CLA signed and sent.

tfarago avatar Aug 30 '22 11:08 tfarago

Thanks @tfarago, this will be included in the next 6.10.2 release aimed for a late September release

dgault avatar Aug 31 '22 15:08 dgault

This pull request has been mentioned on Image.sc Forum. There might be relevant details there:

https://forum.image.sc/t/b-c-for-a-whole-virtual-stack-cont/57811/11

imagesc-bot avatar Aug 31 '22 18:08 imagesc-bot

This pull request has been mentioned on Image.sc Forum. There might be relevant details there:

https://forum.image.sc/t/b-c-for-a-whole-virtual-stack-cont/57811/17

imagesc-bot avatar Dec 12 '23 15:12 imagesc-bot