bioformats icon indicating copy to clipboard operation
bioformats copied to clipboard

Memoizer: Persist caching to sub readers

Open dgault opened this issue 5 years ago • 1 comments

Initial PR for testing and discussion of a possible option for passing Memoization to sub readers. In this case each reader must wrap its sub readers, which leaves a significant amount of testing required to cover the large number of readers involved.

  • MetadataOptions used to store Memoizer otpions
  • A wrap method in Memoizer to handle the wrapping
  • Each reader then wraps its sub readers

Likely to be further commits to bring this more inline with the IDR branch New MetaxpressTiffReader also needs to be updated

dgault avatar Oct 07 '20 08:10 dgault

First off, wow. I find this very exciting. I only ever approached propagating to the most necessary readers in the IDR context.

I do wonder if we're doing this across the board now if there are any other wrapping concerns we should consider. I imagine that might work by letting the Options object decide which wrappings to apply.

joshmoore avatar Oct 15 '20 12:10 joshmoore