bioformats
bioformats copied to clipboard
ome
SCN: No color correction for SCN400
This is a test PR for a potential fix to https://github.com/ome/bioformats/issues/3510
Currently color correction is applied for any non Versa systems, in this case an SCN400 system has been used that also does not require correction. Unfortunately I cant find anything else in the metadata that would indicate if correction is or isn't required. Opening this PR as a test to see its impact on other files in the data repo.
A number of repo files have been impacted by this and will need further investigation to confirm if the new pixel values are correct: https://merge-ci.openmicroscopy.org/jenkins/job/BIOFORMATS-test-folder/62923/consolee
Builds and repo tests are now green with the latest config PR included, alternate MD5 values have been added as per the other SCN files as the values differ depending on the Java version.
I don't think we have additional private samples that need testing - the case @sbesson and I discussed earlier is a different format not handled by this reader.
I'm fine with this being merged as-is. As a follow-up, it might be worth an option to make the color correction configurable, so we don't have to worry so much about changes like this in the future. That shouldn't hold up the 6.11.1 release though.
