bioformats icon indicating copy to clipboard operation
bioformats copied to clipboard

UpgradeChecker: proposed deprecations

Open sbesson opened this issue 5 years ago • 0 comments

https://forum.image.sc/t/bioformat-upgrade-matlab/26099 revealed a few issues with the UpgradeChecker installation logic affecting callers like bfUpgradeCheck.

The most prominent issue is that the CI logic within the class is no longer functional. Having the library auto-installing CI artifacts is probably no longer a requirement:

https://github.com/openmicroscopy/bioformats/blob/a28a7cb6e7aa07862dc5a788720ff8032a51fd2e/components/formats-bsd/src/loci/formats/UpgradeChecker.java#L69-L82

For Bio-Formats 6.2.0, a proposal would be to:

  • deprecate TRUNK_BUILD, DAILY_BUILD and all the currently broken codepaths using the CI logic to retrieve the latest stable library instead
  • review the STABLE_BUILDand STABLE_VERSION logic. It feels like we should be able to use the latest URL and there is no longer a need for encoding the STABLE_VERSION directly in the class.
  • review all consumer code including ImageJ and Bio-Formats

sbesson avatar Jun 12 '19 16:06 sbesson