ggseqlogo icon indicating copy to clipboard operation
ggseqlogo copied to clipboard

<scale>` argument of `guides()` cannot be `FALSE`. Use "none" instead as of ggplot2 3.3.4

Open moa4020 opened this issue 1 year ago • 1 comments

Hey!

I'm using ggseqlogo to produce logoplots of Bstringset objects on R. The only line of code I've used ggseqlogo is the line below.

out = ggseqlogo(sequences, method = 'prob' )

The following warning message appeared when I ran the code. I have been getting the right results. But is there something I need to look out for?

Warning message: The <scale> argument of guides() cannot be FALSE. Use "none" instead as of ggplot2 3.3.4. ℹ The deprecated feature was likely used in the ggseqlogo package. Please report the issue at https://github.com/omarwagih/ggseqlogo/issues. This warning is displayed once every 8 hours. Call lifecycle::last_lifecycle_warnings() to see where this warning was generated.

I called 'lifecycle::last_lifecycle_warnings()' as instructed and got the following backtrace.

lifecycle::last_lifecycle_warnings() [[1]] <warning/lifecycle_warning_deprecated> Warning: The <scale> argument of guides() cannot be FALSE. Use "none" instead as of ggplot2 3.3.4. ℹ The deprecated feature was likely used in the ggseqlogo package. Please report the issue at https://github.com/omarwagih/ggseqlogo/issues.


Backtrace:

  1. ggseqlogo::ggseqlogo(sequences, method = "prob")
  2. ggseqlogo::geom_logo(data = data, ...)
  3. ggplot2::guides(fill = F)
  4. ggplot2:::deprecate_warn0("3.3.4", "guides(<scale> = 'cannot be FALSE. Use "none" instead')")

moa4020 avatar Jan 19 '23 18:01 moa4020

Thanks for reporting. Nothing you need to worry about in this version but this will probably break in future versions. I'll address this soon.

omarwagih avatar Jan 19 '23 18:01 omarwagih