deluge-autoremoveplus icon indicating copy to clipboard operation
deluge-autoremoveplus copied to clipboard

Update for Deluge 2.0

Open maximberezin97 opened this issue 5 years ago • 32 comments

This pull request updates the plugin for Deluge 2.0, supporting Python 3 and GTK3.

I followed the steps for updating plugins on this guide.

I have also attached a compiled Python egg of this pull request. AutoRemovePlus-0.6.2-py3.7.zip

Thank you Omar for your work on this very useful Deluge plugin!

maximberezin97 avatar Jun 21 '19 01:06 maximberezin97

Appears to be working.

I do not have many torrents to do a full test on it right now, but it appears to be good to go!

Will update this or the pull request if I encounter any issues.

1n5aN1aC avatar Jun 21 '19 02:06 1n5aN1aC

The egg seems to be working fine even for Python 3.6.

sgabe avatar Jun 22 '19 12:06 sgabe

Unfortunately, it does not appear to be working for me.

The web interface appears to work correctly, but no torrents are removed. I receive the following error:

17:50:54 [CRITICAL][deluge.log                       :93  ] twisted.internet.defer 
[Failure instance: Traceback: <class 'NameError'>: name 'a_b' is not defined
/usr/lib/python3.7/site-packages/deluge/core/rpcserver.py:326:dispatch
/config/plugins/AutoRemovePlus-0.6.2-py3.7.egg/autoremoveplus/core.py:144:set_config
/usr/lib/python3.7/site-packages/twisted/internet/task.py:194:start
/usr/lib/python3.7/site-packages/twisted/internet/task.py:239:__call__
--- <exception caught here> ---
/usr/lib/python3.7/site-packages/twisted/internet/defer.py:151:maybeDeferred
/config/plugins/AutoRemovePlus-0.6.2-py3.7.egg/autoremoveplus/core.py:433:do_remove
/config/plugins/AutoRemovePlus-0.6.2-py3.7.egg/autoremoveplus/core.py:95:<lambda>
]

I have kept my old config file, I will attempt removing it and make sure the behaviour continues.

1n5aN1aC avatar Jun 24 '19 01:06 1n5aN1aC

Unfortunately, same behaviour:

18:45:54 [CRITICAL][deluge.log                       :93  ] twisted.internet.defer 
[Failure instance: Traceback: <class 'NameError'>: name 'a_b' is not defined
/usr/lib/python3.7/site-packages/deluge/core/rpcserver.py:326:dispatch
/config/plugins/AutoRemovePlus-0.6.2-py3.7.egg/autoremoveplus/core.py:144:set_config
/usr/lib/python3.7/site-packages/twisted/internet/task.py:194:start
/usr/lib/python3.7/site-packages/twisted/internet/task.py:239:__call__
--- <exception caught here> ---
/usr/lib/python3.7/site-packages/twisted/internet/defer.py:151:maybeDeferred
/config/plugins/AutoRemovePlus-0.6.2-py3.7.egg/autoremoveplus/core.py:433:do_remove
/config/plugins/AutoRemovePlus-0.6.2-py3.7.egg/autoremoveplus/core.py:95:<lambda>
]

1n5aN1aC avatar Jun 24 '19 01:06 1n5aN1aC

Unfortunately, same behaviour:

18:45:54 [CRITICAL][deluge.log                       :93  ] twisted.internet.defer 
[Failure instance: Traceback: <class 'NameError'>: name 'a_b' is not defined
/usr/lib/python3.7/site-packages/deluge/core/rpcserver.py:326:dispatch
/config/plugins/AutoRemovePlus-0.6.2-py3.7.egg/autoremoveplus/core.py:144:set_config
/usr/lib/python3.7/site-packages/twisted/internet/task.py:194:start
/usr/lib/python3.7/site-packages/twisted/internet/task.py:239:__call__
--- <exception caught here> ---
/usr/lib/python3.7/site-packages/twisted/internet/defer.py:151:maybeDeferred
/config/plugins/AutoRemovePlus-0.6.2-py3.7.egg/autoremoveplus/core.py:433:do_remove
/config/plugins/AutoRemovePlus-0.6.2-py3.7.egg/autoremoveplus/core.py:95:<lambda>
]

Fixed in most recent commit. Missed a variable when refactoring. Try it now with this egg. AutoRemovePlus-0.6.2-py3.7.zip

maximberezin97 avatar Jun 24 '19 18:06 maximberezin97

I can confirm basic removals are working correctly now.

I can not yet confirm if excemptions and specific rules work yet, but both are part of my workflow, so if I have any problems, I'll report back.

Thanks for the update!

1n5aN1aC avatar Jun 25 '19 01:06 1n5aN1aC

Fixed in most recent commit. Missed a variable when refactoring. Try it now with this egg. AutoRemovePlus-0.6.2-py3.7.zip

I'm Still not able to add the plugin. I'm using an ubuntu server with updated python version with web interface

alculete avatar Jun 28 '19 07:06 alculete

Fixed in most recent commit. Missed a variable when refactoring. Try it now with this egg. AutoRemovePlus-0.6.2-py3.7.zip

Atill not able to add the plugin. I'm using an ubuntu server with updated python version with web interface

What platform are you on? Version of Deluge? Ad-blockers in your browser? Have you tried both uploading the egg in the web UI and manually putting it into the plugins directory?

maximberezin97 avatar Jun 30 '19 03:06 maximberezin97

What platform are you on? Version of Deluge? Ad-blockers in your browser? Have you tried both uploading the egg in the web UI and manually putting it into the plugins directory?

Yes tried both and didn't work. I've even installed docker version to test. This is my system

image

alculete avatar Jul 01 '19 11:07 alculete

Same for me, it doesn't work in either Web UI or dropping it in for me either. I use the linuxserver/deluge docker image.

deakster avatar Jul 06 '19 09:07 deakster

What platform are you on? Version of Deluge? Ad-blockers in your browser? Have you tried both uploading the egg in the web UI and manually putting it into the plugins directory?

Yes tried both and didn't work. I've even installed docker version to test. This is my system

image

You haven't told me what version of Deluge you are using nor whether you tried disabling your ad-blocker. I can't isolate the problem unless you give me more information. An error in the Deluge logs would be most helpful.

Same for me, it doesn't work in either Web UI or dropping it in for me either. I use the linuxserver/deluge docker image.

I have tested the plugin both by manually placing the egg and uploading it via web UI on a clean linuxserver/deluge image and config, and it works just fine. Please try using a clean config, as sometimes Deluge's plugin UI doesn't tell you when something goes wrong with a plugin. You may also try manually adding the AutoRemovePlus plugin to the enabled plugins setting in your core.conf.

Since I have not yet received any reports of errors that have proven to be related to my changes, I am reopening this PR.

maximberezin97 avatar Jul 20 '19 15:07 maximberezin97

For those having installation issues: I was able to get this version working: https://github.com/omaralvarez/deluge-autoremoveplus/files/3322062/AutoRemovePlus-0.6.2-py3.7.zip

I manually installed the .egg into the plugin directory in Deluge. There were some old copies of the plugin and a weird directory that I cleared out beforehand. Restarted deluge and it seems to work.

luciusbono avatar Jul 22 '19 05:07 luciusbono

For those having installation issues: I was able to get this version working: https://github.com/omaralvarez/deluge-autoremoveplus/files/3322062/AutoRemovePlus-0.6.2-py3.7.zip

I manually installed the .egg into the plugin directory in Deluge. There were some old copies of the plugin and a weird directory that I cleared out beforehand. Restarted deluge and it seems to work.

I have placed the .egg within the plugins directory for my deluge docker container, but it still does not show up within the webui. I have restarted the container.

Using latest Deluge Docker Container.

Version: Deluge 2.0.3-2-201906121747-ubuntu18.04.1

I tried using Chrome and internet explorer and neither worked. Also tried incognito in Chrome.

clifford64 avatar Jul 26 '19 01:07 clifford64

For those having installation issues: I was able to get this version working: https://github.com/omaralvarez/deluge-autoremoveplus/files/3322062/AutoRemovePlus-0.6.2-py3.7.zip I manually installed the .egg into the plugin directory in Deluge. There were some old copies of the plugin and a weird directory that I cleared out beforehand. Restarted deluge and it seems to work.

I have placed the .egg within the plugins directory for my deluge docker container, but it still does not show up within the webui. I have restarted the container.

Using latest Deluge Docker Container.

Version: Deluge 2.0.3-2-201906121747-ubuntu18.04.1

I tried using Chrome and internet explorer and neither worked. Also tried incognito in Chrome.

Try

python3 -V

If it's 3.6.8, rename the file to 3.6 instead of 3.7 and it should work.

wogam avatar Jul 30 '19 11:07 wogam

For those having installation issues: I was able to get this version working: https://github.com/omaralvarez/deluge-autoremoveplus/files/3322062/AutoRemovePlus-0.6.2-py3.7.zip I manually installed the .egg into the plugin directory in Deluge. There were some old copies of the plugin and a weird directory that I cleared out beforehand. Restarted deluge and it seems to work.

I have placed the .egg within the plugins directory for my deluge docker container, but it still does not show up within the webui. I have restarted the container. Using latest Deluge Docker Container. Version: Deluge 2.0.3-2-201906121747-ubuntu18.04.1 I tried using Chrome and internet explorer and neither worked. Also tried incognito in Chrome.

Try

python3 -V

If it's 3.6.8, rename the file to 3.6 instead of 3.7 and it should work.

That worked. Thank you.

clifford64 avatar Jul 30 '19 12:07 clifford64

Thanks a lot! It's working. If you have time then please take a look at this plugin too. https://dev.deluge-torrent.org/wiki/Plugins/YaRSS2

ghost avatar Aug 02 '19 02:08 ghost

I tried installing this egg in the webUI of Deluge 2.0.3 but nothing happened. When I installed it using the GTK client, it immediately appeared in the list of available plugins.

Does this mean installing egg's is only supported in the GTK client? Sorry, I'm fairly new to Deluge.

kevindd992002 avatar Aug 22 '19 08:08 kevindd992002

I tried installing this egg in the webUI of Deluge 2.0.3 but nothing happened. When I installed it using the GTK client, it immediately appeared in the list of available plugins.

Does this mean installing egg's is only supported in the GTK client? Sorry, I'm fairly new to Deluge.

Try installing the egg manually by copying it to /.config/deluge/plugins folder.

ghost avatar Aug 22 '19 09:08 ghost

If you re-read my post, I was able to install it already. My question was more out of curiosity as to why the GTK client installation worked but not the WebUI client method.

kevindd992002 avatar Aug 22 '19 09:08 kevindd992002

If you re-read my post, I was able to install it already. My question was more out of curiosity as to why the GTK client installation worked but not the WebUI client method.

Web-ui doesn’t upload the egg properly. The uploaded file has an invalid name.

ghost avatar Aug 22 '19 11:08 ghost

Yes, that I figured as much and I thought that was fine. But that makes sense now. Thanks for the answer.

kevindd992002 avatar Aug 22 '19 12:08 kevindd992002

Hi, trying to install this on windows deluge v2, i managed to do so by placing the egg manually on plugin folder and rename it to 3.6 But it doesnt show config page, any thoughts?

Buster14 avatar Oct 02 '19 16:10 Buster14

Just commenting to say I downloaded the egg, renamed to 3.6, restarted Deluge, and everything worked as expected. Thank you!

rkuykendall avatar Oct 26 '19 15:10 rkuykendall

Hi, trying to install this on windows deluge v2, i managed to do so by placing the egg manually on plugin folder and rename it to 3.6 But it doesnt show config page, any thoughts?

Having the same issue here. Can see the plugin listed and can check to enable, but no config page. Logs do list the following, so it looks like the plugin is running.

02:33:46 [WARNING ][deluge.plugin.autoremoveplus.core:133 ] check interval loop starting

IsThisNameGoodEnough avatar Dec 22 '19 02:12 IsThisNameGoodEnough

Hello! Sorry to bother you but i'm getting stuck: I have installed the plugin and i can see it showing in deluge WEBUI but i cant activate it: i tick the plugin to activate it, then apply an close, but nothing get activated neither listed in the side menu of the settings and once i come back to the settings, the plugin is back to unticked.

Does any of you already had to deal with this?

EDIT: nevermind: got it working: got: https://github.com/omaralvarez/deluge-autoremoveplus/files/3322062/AutoRemovePlus-0.6.2-py3.7.zip renamed to 3.6 instead of 3.7

antipiot avatar Dec 23 '19 09:12 antipiot

Sooo much back and forth with this before I found this pull request. FINALLY got it working by renaming the egg to 3.6 instead of 3.7.

Thanks everyone for spreading the knowledge and a great plugin! Seems like a common issue this. Perhaps worth mentioning on the index page?

superdonpan avatar Jun 17 '20 01:06 superdonpan

Thanks for this. I also got this working by renaming to 3.6, even though python3 -V reports 3.7.0 which is weird.

dmm-john avatar Aug 11 '20 21:08 dmm-john

I can't seem to get this plugin to install. Tried naming it to AutoRemovePlus-0.6.9-py3.6 and AutoRemovePlus-0.6.9-py3.7 but neither worked.

wgstarks avatar Sep 26 '20 20:09 wgstarks

I can't seem to get this plugin to install. Tried naming it to AutoRemovePlus-0.6.9-py3.6 and AutoRemovePlus-0.6.9-py3.7 but neither worked.

Remove the python moniker (I.e. label it AutoRemovePlus-0.6.9) and it should work.

wogam avatar Sep 26 '20 20:09 wogam

I can't seem to get this plugin to install. Tried naming it to AutoRemovePlus-0.6.9-py3.6 and AutoRemovePlus-0.6.9-py3.7 but neither worked.

Remove the python moniker (I.e. label it AutoRemovePlus-0.6.9) and it should work.

Outstanding. Worked perfectly.

wgstarks avatar Sep 26 '20 21:09 wgstarks