Oskar Mansfeld
Oskar Mansfeld
Is it correct that all stats are already exposed to `neqo_glue` and all that's needed to record something to glean is to add a probe and record it in `record_stats_in_glean`...
@mxinden suggested it might make sense to instead of `late_ack / lost` track `late_ack / congestion_event` as multiple lost packets could be part of the same congestion event (the first...
@mxinden > Sounds good. Minor suggestion, consider adding a spurious_event_encountered: bool to the following two enum variants: Why those two specifically? We can also encounter a spurious event while in...
Might fix as part of #2535 but I wanted to note it down for future reference anyways.
I'll start working on this! Are there any places where we don't want to get rid of the module name repetitions? As far as I can see we allow them...
I'd like some feedback on the following before eventually tackling more of this refactor! The way we did it in #2311 (like in Max's example above) we would eventually end...
Thanks for the feedback, I'll keep it as is then. Will put the refactor in my backlog and chip away at it when I have bandwidth.
It looks like all the `allow`'s were removed in #2456 so now `cargo clippy` spits out loads of warnings.
I just literally run barebone `cargo clippy` on the latest commit and there are 93 mentions of `module_name_repetitions` in the output.
Yes, I was still on 1.83.0 and now used that opportunity to update. Don't see it on 1.86.0 anymore. I'm curious in case you know, what was changed between toolchain...