Omkar Mestry
Omkar Mestry
@zsiegel92 Actually, we had added shapely few version earlier, but it is used for some other functions, I have one question did you increased the chunk size parameter, I bet...
@zsiegel92 By default the chunk_size is 1, but can you try by setting it to 9? Following is the new signature of the function. ``` def points_within_polygon( points: Union[Feature, FeatureCollection],...
@zsiegel92 the chunk_size parameter means same as the chunk_size present in multiprocessor.map please refer to this document https://docs.python.org/release/2.6.6/library/multiprocessing.html#multiprocessing.pool.multiprocessing.Pool.map
@zsiegel92 I think further improvement can be done by improving the turfpy.measurement.boolean_point_in_polygon, and then it works faster than shapely as well.
And really Thank You !!! for doing such a great investigation :)
@madolson Yeah I will close it next 1-2 days is it fine ?
@madolson found some time so updated the PR :)
@zuiderkwast can you help to understand like why are the test failing with `Configuration issue prevented Valkey startup` ?
@zuiderkwast @madolson can you please review, I have fixed all the open items
The test were passing earlier like I just changed the text, that shouldn't fail the test :) Is it because of flakiness of the tests ?