winstall icon indicating copy to clipboard operation
winstall copied to clipboard

Continue on Error

Open matyhaty opened this issue 5 years ago • 2 comments

I created a collection of around 35 apps, which is superb

However some of them throw errors and kill it. While obviously they need reporting individually, it would make sense to allow the script to continue, otherwise its somewhat of a chore to manually re-paste in

Also, if a app is already found, if possible it should give you an option to skip or re-install (pre download) I might look at BAT file options for this.#

Finally the cut and paste would be easier to read for resarting purposes if there was a line break at the end of each comment, after the &&

matyhaty avatar Nov 14 '20 08:11 matyhaty

Adding a few lines around the Bat entries, and you get a much better experience:

echo ------------------------------------------------------------------
echo Installing *** Put Name of App here ***
winget install --id=Oliverschwendener.Ueli -e
if ERRORLEVEL 1 (
    echo.
    echo --- Warning
    echo --- Application may not have correctly installed, see output above.
    echo.
)
echo ------------------------------------------------------------------
echo.
echo.

matyhaty avatar Nov 14 '20 10:11 matyhaty

Hey, good point, would you be able to send a PR for this? The files where the scripts are generated are as follows:

  • https://github.com/MehediH/winstall/blob/master/pages/packs/%5Bid%5D.js#L41
  • https://github.com/MehediH/winstall/blob/master/pages/generate.js#L16

MehediH avatar Nov 14 '20 10:11 MehediH