BarterDude icon indicating copy to clipboard operation
BarterDude copied to clipboard

Using aiologger in favor of python-json-logger

Open diogommartins opened this issue 5 years ago • 2 comments

Motivations:

  1. Since BarterDude depends on async-worker, BarterDude already depends on aiologger, which means that the change won't add a new dependency. Instead, we'll be removing one!
  2. It will give BarterDude an easy performance boost, contributing to it's fully async design! (It's an old post, but a more detailed explanation can be found here)
  3. It has a built-in JSON logger, and it's a well documented and pretty straightforward to integrate with the project. Eg.: aiologger usage in asyncworker

Do you guys think that it's ok if I submit a PR with the changes need to use aiologger instead of python-json-logger?

diogommartins avatar Jun 25 '20 22:06 diogommartins

Please yes! \o/

dmvieira avatar Jun 26 '20 00:06 dmvieira

That would be great! As I said, the main problem that we encountered was capturing the logs in tests.

gligneul avatar Jun 26 '20 12:06 gligneul