oltpbench icon indicating copy to clipboard operation
oltpbench copied to clipboard

Update OLTPBench to Tim's OLTPBench.

Open lmwnshn opened this issue 4 years ago • 2 comments

See #362.

This issue tracks the current merge plan:

  • [x] Create a separate branch B.
    • [x] B = https://github.com/oltpbenchmark/oltpbench/tree/oltpbench_tim
  • [x] Finish any nitpicks on #362.
    • [x] I have finished enough nitpicks to be comfortable merging. Future PRs can address more changes; it will be easier to review if we break it up.
  • [x] Merge #362 into B.
  • [x] Move src/com back to src/main/java/com.
    • [x] This should make the project buildable. #367
  • [x] Move the data files back.
    • [x] This should make the project runnable. #368

(space)

  • [x] ~~Merge Ziqi's tests with the old tests.~~ The "tests" were actually never run in CI. Taking a little more time to DIY fix.
    • [x] This should make the project tests run successfully.
  • [x] Remove dummy files that we added back to reduce diff size. #368
  • [x] Restore HSQLDB Catalog code.
  • [x] Test that NoisePage works with OLTPBench manually.

(space)

  • [x] Update NoisePage CI to point to B, and invoke new OLTPBench.
  • [x] Add CI to exercise similar code path to old Travis.
  • [ ] Merge B into master.
  • [ ] Update NoisePage CI to point to master.
  • [ ] Delete B.

Time targets have shifted due to travel and quarantine. In this room, I can pick between having a monitor or having wifi.


Separately, we should

  • [x] Contact Tim to ask about maintainer details for POM, Dockerfile, etc. -- Tim is OK as maintainer.

lmwnshn avatar Jun 17 '21 19:06 lmwnshn

~~As of 20 Jul, I am trying to figure out a bug with TPCC/OrderStatus in NoisePage that is manifesting with this version of OLTPBench.~~

Resolved, the DDL got messed up and I didn't notice.

lmwnshn avatar Jul 20 '21 11:07 lmwnshn

Working on #382

lmwnshn avatar Jul 29 '21 07:07 lmwnshn