oltpbench icon indicating copy to clipboard operation
oltpbench copied to clipboard

Inconsistant Metrics Labels

Open bialesdaniel opened this issue 4 years ago • 0 comments

The metric labels for the .summary file and the .res file look very different. .res looks like this:

time(sec), throughput(req/sec), avg_lat(ms), min_lat(ms), 25th_lat(ms), median_lat(ms), 75th_lat(ms), 90th_lat(ms), 95th_lat(ms), 99th_lat(ms), max_lat(ms), tp (req/s) scaled

.summary looks like this:

public Map<String, Double> toMap() {
	Map<String, Double> distMap = new LinkedHashMap<String, Double>();
		distMap.put("Minimum Latency (milliseconds)", getMinimum() / 1e3);
		distMap.put("25th Percentile Latency (milliseconds)", get25thPercentile() / 1e3);
		distMap.put("Median Latency (milliseconds)", getMedian() / 1e3);
		distMap.put("Average Latency (milliseconds)", getAverage() / 1e3);
		distMap.put("75th Percentile Latency (milliseconds)", get75thPercentile() / 1e3);
		distMap.put("90th Percentile Latency (milliseconds)", get90thPercentile() / 1e3);
		distMap.put("95th Percentile Latency (milliseconds)", get95thPercentile() / 1e3);
		distMap.put("99th Percentile Latency (milliseconds)", get99thPercentile() / 1e3);
		distMap.put("Maximum Latency (milliseconds)", getMaximum() / 1e3);
		return distMap;
	}

Also, it seems like writeCSV2 is still using microseconds and I think it makes sense to stick with milliseconds since that is used elsewhere. https://github.com/oltpbenchmark/oltpbench/blob/dc32a26a2dc308c3ca75a7176b997d3a7b30b5c2/src/com/oltpbenchmark/Results.java#L109

I propose we use constants to standardize the labeling and the units

bialesdaniel avatar Sep 20 '20 07:09 bialesdaniel