oltpbench icon indicating copy to clipboard operation
oltpbench copied to clipboard

Remove nonfunctional pom.xml.

Open bimargulies-google opened this issue 7 years ago • 6 comments

bimargulies-google avatar Dec 14 '18 19:12 bimargulies-google

How hard would it be to just fix this?

apavlo avatar Dec 15 '18 16:12 apavlo

There are not a lot of good ways in Maven to deal with the collection of not-on-Maven-central dependencies. When the pom last worked, it was just Oracle, but now it's more.

I could look at two strategies.

1: gradle instead of Maven. 2: taking all those JDBC drivers out of the Maven dependency graph. Nothing should be referencing them at compile time anyway.

Which would you prefer?

On Sat, Dec 15, 2018 at 8:44 AM Andy Pavlo [email protected] wrote:

How hard would it be to just fix this?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/oltpbenchmark/oltpbench/pull/272#issuecomment-447581408, or mute the thread https://github.com/notifications/unsubscribe-auth/AX8h5bUr1GFoKUMqxFdUcGD-D1BClcIjks5u5Sb-gaJpZM4ZUK0n .

-- Benson Margulies

bimargulies-google avatar Dec 15 '18 17:12 bimargulies-google

@bimargulies-google We should probably switch to gradle. This is something that we have talked about but just didn't have time to do it.

apavlo avatar Dec 15 '18 17:12 apavlo

I'll have myself a look.

On Sat, Dec 15, 2018 at 9:55 AM Andy Pavlo [email protected] wrote:

@bimargulies-google https://github.com/bimargulies-google We should probably switch to gradle. This is something that we have talked about but just didn't have time to do it.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/oltpbenchmark/oltpbench/pull/272#issuecomment-447586047, or mute the thread https://github.com/notifications/unsubscribe-auth/AX8h5Xf3c8y88n4fQzC5OkpEIg3XiYhoks5u5TeCgaJpZM4ZUK0n .

-- Benson Margulies

bimargulies-google avatar Dec 15 '18 17:12 bimargulies-google

I've got a gradle build. There's some cleanup if you want to commit to it -- deleting almost all of 'lib', and fixing up travis. To try it:

gradle installDist

./dist/bin/oltpbenchmark -b tpch -c config/tpch_sqlite.xml --create=true --load=true --execute=true -s 5 -o outputfile

Unfortunately, this hits an NPE even with the ant build on master, so I can't tell for sure that I've got all this sorted. Ideas?

bimargulies-google avatar Dec 16 '18 18:12 bimargulies-google

@bimargulies-google Thanks for doing this. Can you be more specific about how to reproduce the NullPointerException?

apavlo avatar Dec 28 '18 14:12 apavlo