Michael Olšavský comments

Results 24 comments of


                                            Michael Olšavský

Fix schema validate error

I know this library is deprecated for over a year now but it'd really help to fix or rather just generate proper schema.json from the source that is already in...

Switch the default mockmaker to the inline mockmaker on JDK 17+

Perhaps we could reflect this behavior in the Mockito documentation until the switch to mockito-inline is merged? I can see the inline mock maker mentioned for final types & final...

DynamicFunctionReturnTypeExtension / DynamicFunctionThrowTypeExtension not executed for anonymous functions

I definitely like the proposal! It would cover the whole functionality of the rule we're using now + it would have better DX. Anyway though, the issue was not meant...

[kotlin] [client] Implement inheritance and oneOf support in kotlin-client

Finishing this would be very much welcome! What's the reason behind closing this PR, please?

JsonJacksonApprovals should accept instance of ObjectMapper

Since Jackson supports ordering of properties and map entries out of the box (ORDER_MAP_ENTRIES_BY_KEYS, SORT_PROPERTIES_ALPHABETICALLY options), allowing to pass an instance of ObjectMapper will make the JsonJacksonApprovals implementation on par...

Ability to add custom `PhpParser\NodeVisitor` to alter AST attributes

I would argue that the proposed https://github.com/qossmic/deptrac-src/pull/21 is a sweet spot between introducing a public extension point in the Deptrac API, and overriding the internals (which is something we have...

[Documentation] Note that resources in native executables should be loaded via getResourceAsStream

ping @kassifar :)

implode/join with null as second argument throws but is not caught by the rule

@ondrejmirtes I don't think this logic belongs to neither the SignatureMapProvider or ParamtersAcceptorSelector as the stubs are correct. The problem is that the function definition is too dynamic -> it...

implode/join with null as second argument throws but is not caught by the rule

Ok, that makes sense, thanks! I guess right now there is no support for multiple function signatures? I see `\PHPStan\Reflection\SignatureMap\Php8SignatureMapProvider::hasFunctionSignature` does support variants but I was not able to find...

Allow to define prune by default for manual sync applications

A separate config option would be very much appreciated. Forgetting to call `prune` after deploy has caused us production issues multiple times and we can't enable autosync on all our...