fusesoc icon indicating copy to clipboard operation
fusesoc copied to clipboard

Published 20 hours ago • verified publisher icon olofk

Pathlib migration

Open dominicdoty opened this issue 4 years ago • 3 comments

Now that the minimum Python required version has moved up to 3.6, pathlib migration should be possible.

Addresses: #376 #458

dominicdoty avatar Mar 30 '21 04:03 dominicdoty

Hi @dominicdoty, thanks for your pull request! It's a good start, but will need a bit more work to pass our CI tests.

I'd recommend running the tests locally as documented at https://fusesoc.readthedocs.io/en/latest/dev/devsetup.html#running-tests to see where the failures come from.

If you have problems understanding the failures, with GitHub, or anything of that sort, please reach out and we can help you through it.

imphil avatar Apr 01 '21 18:04 imphil

Apologies, I was a bit premature in my pull request, didn't realize it would show up and run tests while still a draft :grimacing:

I'm working my way through the rest of the files in the repo over the next few days.

dominicdoty avatar Apr 02 '21 03:04 dominicdoty

Don't worry and no hurry! I only wanted to make sure we're on the same page and not both wait for the other person to act :smile:

imphil avatar Apr 05 '21 19:04 imphil

This wasn't intended to be closed. It happened when I renamed the default branch. Please reopen if it's still relevant

olofk avatar Oct 31 '22 22:10 olofk

Let's leave it closed for now, got pulled in another direction for the moment.

Still interested in coming back to this in the future.

dominicdoty avatar Nov 01 '22 15:11 dominicdoty