fusesoc
fusesoc copied to clipboard
olofk
Add support for specifying library version
This commit adds a new option sync-version to the config file and the library subcommand for the cli tool. This option is passed through to the provider used for a library to specify a version of the library to use. This change also updates the git provider to use the sync-version to checkout a commitish on a git-provided library. This libraries to be fixed at certian points, or follow specific branches (such as nightly or stable)
Hi, Thank you for the contribution. It took far too long for me to get to this. I think it's good to have this functionality. At the same time I have been debating (with myself, so only half a brain) if it's worth the added complexity or if it can be easily solved outside of FuseSoC. But I think it's worth it after all. On top of the use cases you presented I'm thinking of cases where I have added some experimental feature to a branch and just want to pass someone a one-liner so they can test out the library for themselves.
Since some time has passed since you originally wrote this, it seems there are now some merge conflicts. We are also closing in on a new release and I would prefer to get that done before merging this. So once the 1.12 release is out, would you mind rebasing this to master and I'll push it right away. If you're unable to, I'll do it myself eventually
Hello! No worries, once 1.12 is out I'll get on fixing the conflicts :)
@olofk - I've fixed the conflict and I believe this should be good to merge, let me know if there are any other changes needed :)
@olofk / @imphil - is this mergable? Happy to pickup any further changes as needed :)
This wasn't intended to be closed. It happened when I renamed the default branch. Please reopen if it's still relevant
For posterity, I can mention that I managed to salvage these patches and they are now committed