Olof Kindgren

Results 561 comments of Olof Kindgren

I don't have any opinions on what linter to use, but it looks like it picked up some nice clean-ups at least, so I'm happy to give it a go....

The patch looks mostly fine from a quick look but there are some issues, like the hardcoded version string. The test cases also aren't updated, so the tests are failing...

There are several issues with the genus interface and should be rewritten from scratch for the Flow API. I have other things I need to focus on right now though,...

Ah! Missed that this was a PR and not an issue and that you had provided a fix. I'm generally sceptic towards adding more features to the backends using the...

Thanks. Could you also update the reference files accordingly so that the test suite passes? Some more info about testing and using the `GOLDEN_RUN` env var to update files automatically...

Alright. Picked and pushed! Thank you for your contributions.

Ok, this is a very simple patch so I will pull it in after the test case reference files are also fixed. But generally, I will not allow any more...

This is fixed now with 9cdb8766cb5f1ac2cf612261b8f47cdbf081956f

Ok, that's not good. It's a bit surprising that they didn't make WFI support optional in Zephyr. Either way, I think that we should short-term fix SERV to treat WFI...

Thanks for adding this. Bonus points for also adding tests. Unfortunately this implementation is written for the Tool API that is about to be deprecated, and all new backends must...