ha-smartthinq-sensors icon indicating copy to clipboard operation
ha-smartthinq-sensors copied to clipboard

Washing machine - run completed not update

Open Keany opened this issue 1 year ago • 3 comments

Hello,

last versions binary_sesnsor entity Run completed doesnt work for Washing Machine.

image

image

Plugin version 0.38.0

HA: Core 2024.2.0 Supervisor 2024.01.1 Operating System 11.5 Frontend 20240207.0

Keany avatar Feb 09 '24 14:02 Keany

There are no change in this last about that sensor!!!! Please provide detail about your issue. Provide log, diagnostics and information about difference between expected behavior. Does not work is not enough.

ollo69 avatar Feb 09 '24 14:02 ollo69

Expected: after run completed of washing machine there should be binary_sensor for several sec on, but now is still off.

This error is not related to the latest version, for me it was not working about 3 versions back.

I turned logging on now for more data.

For Dryer it is working fine.

For example: image

Washing machine: image

Diagnostic: smartthinq_sensors-d773923c731a7bddbd1b879f705e5d51-PRAČKA-ec6df405829df634f62870bef921295d.json

Keany avatar Feb 09 '24 14:02 Keany

Ok, here is a more clear context, we can analyze this. First of all please consider that run completed is a calculated sensor and is not provided by device. The check done is comparing run state and pre state, so the first think to analyze is: what are the status for this 2 sensors on your washer machine when run_completed should be on? Can you check and provide this information?

ollo69 avatar Feb 09 '24 15:02 ollo69

run state and pre state was washing, rinsing. but run completed is still off.

Log: home-assistant_2024-02-11T09-44-02.223Z.zip

Keany avatar Feb 11 '24 09:02 Keany

IMG_0762 IMG_0763

Keany avatar Feb 11 '24 09:02 Keany

Problem here is that your device always return same value for run_state and pre_state. I will think about a possible solution for this case...

ollo69 avatar Feb 11 '24 10:02 ollo69

Please try last release, now pre_state is calculated when equal to run_state. Not sure if this work, because in any case your device should go in END state that I don't see in your logs.

ollo69 avatar Feb 11 '24 22:02 ollo69

I tried last release but no change.

image

home-assistant_2024-02-15T09-14-50.169Z.log

image

Keany avatar Feb 15 '24 09:02 Keany

As I see from your image there is a big change, run_state and pre_state are not equal anymore. I do not understand the meaning of what is written, but what are the value (in english) of pre_state and run_state when wash is completed?

ollo69 avatar Feb 15 '24 10:02 ollo69

pre_state is spinning and run state is standby mode

Keany avatar Feb 15 '24 10:02 Keany

So your device go directly from spinning to standby when it complete the cycle? There are no "END" state?

ollo69 avatar Feb 15 '24 10:02 ollo69

Yes, there is no "END"

Today:

sensor.pracka_pre_state,Pohotovostní režim,2024-02-15T07:50:03.329Z - STANDBY sensor.pracka_pre_state,Vážení,2024-02-15T07:50:33.331Z - Weighing sensor.pracka_pre_state,Praní,2024-02-15T07:51:03.337Z - Washing sensor.pracka_pre_state,Přerušení,2024-02-15T07:52:33.345Z - Paused (small child :D) sensor.pracka_pre_state,Praní,2024-02-15T08:19:33.344Z - Washing sensor.pracka_pre_state,Máchání,2024-02-15T08:39:03.352Z - - Rinsing sensor.pracka_pre_state,Odstřeďování,2024-02-15T08:49:03.353Z - Spinning

And thats all.

Keany avatar Feb 15 '24 12:02 Keany

Please try last release and let me know if it works. I implemented some logics based on states and remaining time, not so perfect but I don't see other options for this case...

ollo69 avatar Feb 18 '24 16:02 ollo69

I tried and looks more better. Bur one thing. Now is Run completed ON forever. For dryer only 30sec. Look on screenshots.

IMG_0819 IMG_0818

Keany avatar Feb 18 '24 20:02 Keany

Need a list of status change and remain time information for both devices when run completed is triggered and than deactivated

ollo69 avatar Feb 18 '24 20:02 ollo69

I suppose that pernamently means until cycle is started again and have to be considered correct behavior

ollo69 avatar Feb 20 '24 07:02 ollo69

Yes it looks like that, I thought that binary run completed only means a short pulse at the end of the cycle for example 1-30s and then it is off again.

So this is currently the correct behavior?

Keany avatar Feb 20 '24 07:02 Keany

Yes, run completed should go on when a cycle is completed and should stay on until you do something with device, like turn it on to start a new cycle, that would set turn completed off. Anyway I'm making a last review that will be released shortly, thanks for details on states

ollo69 avatar Feb 20 '24 08:02 ollo69

Please test last release and let me know if run_completed works as expected / descripted.

ollo69 avatar Feb 20 '24 11:02 ollo69

I close this because duplicated of #226. Please comment on that in case of issue.

ollo69 avatar Feb 21 '24 13:02 ollo69