Nick Krichevsky
Nick Krichevsky
> this.input.show() has to be called before setting the text or else we preselect the initial text (like when coming from visual mode) Oof. Thanks. Just out of curiosity, are...
I hate how fiddly this API is... moving `show()` before setting the value causes the original bug to reappear.
Wrote a small test for this, but unfortunately due to how input is handled for our spawned VSCode instance, it doesn't work like I'd hoped :( Posting it here for...
> The "cancel" button is no longer working, neither is pressing Esc on an empty commandline Already on it. I didn't wanna run the tests locally so I figured I'd...
> The "cancel" button is no longer working, neither is pressing Esc on an empty commandline Actually, I take it back. Neither of these specifically are happening for me. Are...
Wow, that's nasty. It looks like we're racing with `onHide` and `cmdline_hide`, causing the `ignoreHideEvent` flag to be sent longer than we'd like ```2024-06-10T01:29:23.784Z CmdLine: cmdline_show: "0," 2024-06-10T01:29:23.785Z CmdLine: dropping...
> I didn't take the time to understand what the issue with sandwich is, but it seems strange to me that there is a fundamental issue with the current simplistic...
I'm thinking out loud a bit here, but what if we generated an event queue within the `CommandlineManager`? The idea is that if we have a "slice" of cmdline show/hides...
Closing in favor of new PR
I might give this a crack. I often find myself trying to use the minimap to find diagnostics, so I would actually use this