Oliver Margetts

Yes, this is idiomatic python, which means we had to disable this check every time we wrote ```python class MyError(ValueError): """MyError is raised when bla bla bla...""" ```

I think that's the most sensible option. It's not perfect, but you'd still catch simple dataclasses and leave more advanced types alone. Since you can't inspect the MRO in the...

Hi @aamend - thanks for the high quality pull request (including tests, which is nice to see). We totally welcome this kind of interaction with the Fire schemas, however I...

Thanks for the PR. I think the new phrasing is good. However we prefer the British English spelling of "programme" for the European Horizon 2020 Programme - please fix that.

Also, the final comma here is not grammatically correct: `It is also used for policy, monitoring and, supervision purposes.`

The biggest decision to make is whether to allow ISO-3166-2 in the country field, or have a separate "subdivision" field like: ```json "country": "AE", "subdivision": "AE-DU", ``` Note that subdivision...

BOE treats Dubai, Abu-Dhabi and the rest of the UAE differently. And the Fed treats various US states differently. Slightly ridiculous to be able to put Camden for the country...

> As of 3 March 2022 there are 5,048 codes defined in ISO 3166-2. I'm not sure 5000 codes is something we want directly in the fire standard though? Should...

> perhaps where we assigned a code before the ISO standard was updated AG has been ISO for Antigua since 1974, when it was created, so I doubt that ;D

The same here with `Celery 4.4.7` and `rabbitmq:3.8`. An unrecoverable error caused by a long-running job on some production systems. Systems on 3.8.14 were OK, and 3.8.16 not.