ollama-python icon indicating copy to clipboard operation
ollama-python copied to clipboard

Suggestion: Use models to encapsulate request/responses

Open sachinsachdeva opened this issue 1 year ago • 1 comments

consider using models to properly encapsulate request/responses

for example

import ollama
response = ollama.chat(model='llama2', messages=[
  {
    'role': 'user',
    'content': 'Why is the sky blue?',
  },
])
print(response['message']['content'])

would become something like

import ollama
from ollama.models import ChatMessageRequest, ChatMessageResponse

messages: [ChatMessageRequest] =  [ChatMessageRequest('user' , 'Why is the sky blue?')]
response: ChatMessageResponse = ollama.chat(model='llama2', messages=messages)

print(response.content)

sachinsachdeva avatar Jan 27 '24 19:01 sachinsachdeva

:heavy_plus_sign: :one:

adriens avatar Jan 31 '24 10:01 adriens