has_permalink icon indicating copy to clipboard operation
has_permalink copied to clipboard

Published 20 hours ago • verified publisher icon olkarls

Don't autofix for the Objects own ID

Open rsiddle opened this issue 10 years ago • 1 comments

When the model is updated, the current where clause checks against all permalinks for the model including its own ID which will always return true. Therefore it should be excluded as the model can override its own permalink.

rsiddle avatar Jun 06 '14 11:06 rsiddle

Hi Ryan!

Thanks for your feedback! I'm sorry but I can't reproduce the bug, I've added a test to make sure the permalink isn't increased: https://github.com/olkarls/has_permalink/commit/732d115169d096ba79e176cb0da3362ed4d30271#diff-047fe204240af3473750d69298c03498 . Am I missing something?

Thanks

olkarls avatar Jun 30 '14 19:06 olkarls