Oliver Hine comments

Results 126 comments of


                                            Oliver Hine

Refine multipart requests handling

Released `0.1.33`

Unable to use external $ref's with OpenAPI

Hello, So do you think there is a bug - it should throw an exception? Otherwise I think the answer given there - that you can pre-walk with your own...

Output is printed directly

Hi @marksto thanks for helping with this, and yes, I agree about the logging

Question: Request Body not contained in bootstrap result (Unlikely bug, likely user-error or OpenAPI spec error)

Hi, My suspicion is that martian, knowing it doesn't properly support the form content type, is not traversing down into the specification of the body. However I think it could,...

Question: Request Body not contained in bootstrap result (Unlikely bug, likely user-error or OpenAPI spec error)

That ref will be resolved by this code: https://github.com/oliyh/martian/blob/master/core/src/martian/openapi.cljc#L146 However Martian is still not looking inside the form-urlencoded bit because it doesn't have an encoder / decoder for that. It...

Question: Request Body not contained in bootstrap result (Unlikely bug, likely user-error or OpenAPI spec error)

Hi, Your solution looks good, I expect that to work. I'll see if I can find time to have a look. Cheers

Question: Request Body not contained in bootstrap result (Unlikely bug, likely user-error or OpenAPI spec error)

Hi, Have a look at the branch `form-encoder`, and the two commits above - I believe this should work? Cheers

Question: Request Body not contained in bootstrap result (Unlikely bug, likely user-error or OpenAPI spec error)

Hi, Thanks for the feedback! I will merge this and tag a release. Cheers

Question: Request Body not contained in bootstrap result (Unlikely bug, likely user-error or OpenAPI spec error)

That is what I did :)

Support appsync subscription

Hi, Thanks for this! I really appreciate the contribution. Do you know if the "subscriptions as data" is a common pattern, or is it something unique to Appsync? My inclination...