react-swipeable-views icon indicating copy to clipboard operation
react-swipeable-views copied to clipboard
verified publisher icon oliviertassinari

Fixing deprecated UNSAFE_* warnings in the console

Open korbav opened this issue 4 years ago • 21 comments

  • Removing all the UNSAFE_* calls and replacing them with mixed usage of :

    • componentDidUpdate
    • getSnapshotBeforeUpdate
    • constructor

  • Adapting one test to reflect the change

korbav avatar Sep 24 '21 14:09 korbav

Hi @oliviertassinari , could you please take a look? 👍

korbav avatar Sep 30 '21 06:09 korbav

Bump Please merge when possible, I am migrating from React 16.x to 17.x in order to support new MUI(-x) ;)

kelexel avatar Oct 06 '21 02:10 kelexel

👍

simonjohansson avatar Oct 13 '21 15:10 simonjohansson

A merge would be lovely ;)

buigabor avatar Nov 18 '21 10:11 buigabor

I wholehartedly concur

simonjohansson avatar Nov 18 '21 14:11 simonjohansson

I have published this PR on NPM if that can be useful for anyone. Add it like this in your package.json: "react-swipeable-views": "npm:@gromy/react-swipeable-views@^0.15.1",

Grsmto avatar Dec 03 '21 19:12 Grsmto

@Grsmto thanks, but your fork throws this:

Module not found: Error: Can't resolve 'react-swipeable-views-core' in '.../react-swipeable-views/lib'

rm -rf node_modules and lock file doesn’t help.

nevolgograd avatar Dec 06 '21 18:12 nevolgograd

@nevolgograd could you try again with 0.15.1?

Grsmto avatar Dec 06 '21 19:12 Grsmto

@Grsmto noice, error gone. Thanks!

nevolgograd avatar Dec 06 '21 19:12 nevolgograd

@Grsmto @korbav is it possible to fix unsafe methods for react-swipeable-views-utils also? There are only two of them for each util. Would really appreciate it.

nevolgograd avatar Dec 06 '21 19:12 nevolgograd

@Grsmto @korbav is it possible to fix unsafe methods for react-swipeable-views-utils also? There are only two of them for each util. Would really appreciate it.

@nevolgograd This PR already includes a fix for it

https://github.com/korbav/react-swipeable-views/blob/edf1e98210a20a5dab80aa96fc16cf5acfb850eb/packages/react-swipeable-views-utils/src/virtualize.js#L29-L50

korbav avatar Dec 07 '21 06:12 korbav

any chance we could get a merge on this?

millermeares avatar Feb 27 '22 19:02 millermeares

@oliviertassinari hey man, would be cool to merge this finally <3 thanks

kgaregin avatar Apr 02 '22 18:04 kgaregin

Bumping this, so it gets merged

NawarA avatar May 11 '22 20:05 NawarA

why is this pr still not merged? im confused... 😢

xmcodings avatar May 13 '22 12:05 xmcodings

Hello! 👋 Its me, the weekly merge reminder.

simonjohansson avatar May 23 '22 10:05 simonjohansson

@oliviertassinari can you merge this PR or assign someone to merge? A lot of developers are passionate about this issue and are waiting for a merge, thank you 🙏

NawarA avatar May 25 '22 04:05 NawarA

Can we merge please :) @oliviertassinari

mayankmmmx avatar Jul 15 '22 16:07 mayankmmmx

Hi guys, can we please get this merged!

wesleyBBD avatar Aug 02 '22 07:08 wesleyBBD

MERGE THIS

nd-kurnal avatar Sep 16 '22 16:09 nd-kurnal

I have nothing but love for the folks behind this package, but I had to drop this dep.

Its outdated, and in my opinion, deprecated.

PS: I used CSS Scroll Snapping to accomplish something similar in my app.

Much love to everyone

NawarA avatar Sep 16 '22 18:09 NawarA

I'm closing per https://github.com/oliviertassinari/react-swipeable-views/issues/676, thanks for having a look at it.

oliviertassinari avatar Oct 08 '22 17:10 oliviertassinari

why not merge it

shopglobal avatar Apr 28 '23 23:04 shopglobal

NPM supports installing from git repos;

example:

npm i --save-dev oliviertassinari/react-swipeable-views#pull/654/head --force

shopglobal avatar Apr 28 '23 23:04 shopglobal

I have published this PR on NPM if that can be useful for anyone. Add it like this in your package.json: "react-swipeable-views": "npm:@gromy/react-swipeable-views@^0.15.1",

Thanks man!

lucasaljalali avatar Oct 27 '23 19:10 lucasaljalali

kmx kxm?! why current PR is closed?

rafaelpanayiotou avatar Apr 28 '24 14:04 rafaelpanayiotou