react-swipeable-views icon indicating copy to clipboard operation
react-swipeable-views copied to clipboard

could you split pagination out from this package

Open geminiyellow opened this issue 6 years ago • 7 comments

hi @oliviertassinari , why dont you put the pagination.js and paginationdot.js to a new package? swipeable-view may need pagination dot.

for example, react-native-snap-carousel have its pagination.

geminiyellow avatar Sep 05 '18 05:09 geminiyellow

@geminiyellow Good question, yes, we could export it like they do: https://github.com/archriss/react-native-snap-carousel#pagination-component.

oliviertassinari avatar Sep 05 '18 06:09 oliviertassinari

👏 thank you!

and the Cover , we have the code, right, just export it as package looks ok.

geminiyellow avatar Sep 05 '18 07:09 geminiyellow

Can i take this issue?

leonardovillela avatar Oct 22 '18 02:10 leonardovillela

Any updates?

Aendir avatar Dec 04 '18 08:12 Aendir

@leonardovillela take it, kill it, plz.

geminiyellow avatar Dec 04 '18 08:12 geminiyellow

how add pagination to the react swipeable views?

 <div className={classes.sliderSection}>
        <SwipeableViews enableMouseEvents>
          {pictures.map(({ image, title }) => (
            <Paper className={classes.slidCard} key={image}>
              <img src={image} alt={title} />

              <Typography>{title}</Typography>
            </Paper>
          ))}
        </SwipeableViews>
      </div>

NurdinDev avatar Apr 08 '19 13:04 NurdinDev

See https://react-swipeable-views.com/demos/demos/#auto-play for an example with pagination

nataliepan avatar Mar 23 '20 21:03 nataliepan