Olivier Lacan
Olivier Lacan
Thanks @heisters. Since that issue is closed I wonder if @nertzy would consider this nowadays.
I've tested this in a production application and it works perfectly but if you'd like me to add a test I wouldn't mind.
We don't have to check for the environment, I was just mimicking your implementation since you're in suggesting inserting the middleware in production.rb That actually would make sense for me...
@jalada Removed the conditional branch that was checking `Rails.env.production?` I feel like it's the minimum viable conditional at this point. Let me know if you have any other concerns.
> In its current state, will I need to change the major version of the gem? What happens if someone retains the middleware insertion in their config when they upgrade...
Chris Mar gave me a good example for automatic middleware insertion: https://github.com/plataformatec/devise/blob/88724e10adaf9ffd1d8dbfbaadda2b9d40de756a/lib/devise/rails.rb#L22-L27 Granted Devise is a hefty thing but I feel like requiring manual (or semi-manual) addition of an initializer...
Whoops, yeah thanks for the proximity tip. In retrospect that seems obvious. Great to know there's a way to override the default behavior. It's almost as if Yard is very...
@lsegal Somehow despite using the scope directive and separating things properly, I still see these methods defined as instance methods in Yard. Is there a test covering this behavior? I...
I've faced a similar issue yesterday when defining a `@font-face` in Sass. This feature would have the potential to increase legibility substantially. Is anyone here familiar enough with how Sass...
This is feature I've often wanted considering the flurry of flaky networks around the world, it would help users decide whether to give up the download or not. At least...