Olivia Song
Olivia Song
@aaroniscode, yes we plan to upgrade the controller-runtime to v0.15+, but it has breaking changes and may need more time and efforts to investigate and implement corresponding changes. I think...
@jeswinkoshyninan thanks for the contribution, this change looks good to me overall, just a few questions: 1. iiuc, we are supporting filtering the vpc by tags, it does not have...
yeah it's not causing any problem, since it's just return the vpc id if specified. But I think we should call out for this behavior: 1. in `docs/deploy/configurations.md`, add a...
/ok-to-test can you also add the manual testing you've done in the PR description? thanks
/lgtm /assign @M00nF1sh
We set the default value to 1000s(or 16m40s) is to follow the upstream default: https://github.com/kubernetes/client-go/blob/62f959700d559dd8a33c1f692cb34219cfef930f/util/workqueue/default_rate_limiters.go#L52. The value is to cap the max delay to retry a failed item, if decreasing...
/ok-to-test
@dinukarajapaksha, hi, it's an expected behavior for the controller to add the port range based on the min/max values of the ports since v2.3.0. You mean we should only allow...
@stephan242, hi, unfortunately right now we do not allow multiple values for the same key for ingress group and agree we can improve here. /kind feature