oliverpool

Results 166 comments of oliverpool

I updated the settings template, to give some hint regarding the `access_token` (and make it mandatory): ![2022-08-28-121208](https://user-images.githubusercontent.com/3864879/187068809-11be0f82-26db-44de-b1aa-049a8f505a57.png)

I have added a migration to ensure that the `hook_task` doesn't have any remaining `access_token` in its payload.

@Gusted do you have any more comment? Is there anything I can do to move this PR forward? Thanks

@silverwind thanks for the review, I implemented your suggestions. I haved squashed all my commits and rebased on the latest commit of `main`.

@lunny let me know if I can do anything to push this PR forward :-)

The [drone failure](https://drone.gitea.io/go-gitea/gitea/60733/2/16) looks like a glitch `amd64 > test-mssql > TestAPIRepoMigrate` > Migration failed: Clone: exit status 128 - fatal: unable to access 'https://github.com/go-gitea/test_repo.git/': gnutls_handshake() failed: Error in the...

@delvh is there anything I should fix before fixing the conflicts ?

If it is a matrix hook, it is required (as it was before this PR) - albeit only on the frontend now. For other hooks, it is optional.

I can simply hide the help text for now for matrix. This way it is similar to the current form. (As I mentioned, I would prefer this PR to be...

@delvh the help text is now hidden for matrix. I squashed my changes and rebased on top of master.