lunr.js icon indicating copy to clipboard operation
lunr.js copied to clipboard

Published 20 hours ago • verified publisher icon olivernn

Minified CDN version 2.3.8 is actually version 2.3.7

Open Griatch opened this issue 4 years ago • 3 comments

Not sure if this is the correct place to report this ... but cdnjs.com has the wrong version of the minified lunr; it's listed as 2.3.8, but the version string inside is 2.3.7. This causes issues with third-party libraries that create index files for a specific lunr version.

  • https://cdnjs.cloudflare.com/ajax/libs/lunr.js/2.3.8/lunr.min.js is actually 2.3.7
  • https://cdnjs.cloudflare.com/ajax/libs/lunr.js/2.3.8/lunr.js appears to be the correct version

Griatch avatar May 21 '20 14:05 Griatch

Same issue with unpkg.com (https://unpkg.com/[email protected]/lunr.min.js).

simonwiles avatar Aug 18 '20 00:08 simonwiles

So after taking a closer look, it seems the package in NPM is broken, so cdnjs and unpkg and anyone else using the lunr.min.js from the NPM package will have the wrong version.

I was able to checkout the source code and build v2.3.8 of lunr.min.js successfully, however, so I guess it was just a manual packaging error? Hopefully it can be fixed by a package maintainer? @olivernn, are you the only person who can do this? Thanks!

simonwiles avatar Aug 18 '20 03:08 simonwiles

The release of lunr v2.3.9 has been done correctly, fwiw, so this is more of a legacy issue at this point. It should probably still be fixed, though!

simonwiles avatar Sep 22 '20 16:09 simonwiles