Oliver Klee

We should add proper getters and setters for the properties of `OutputFormat`. This should be covered with unit tests similar to this one: https://github.com/oliverklee/ext-oelib/blob/main/Tests/Unit/Domain/Model/GermanZipCodeTest.php#L48 Adding `setIndentation` will also fix a...

We should make the `in_array` calls strict by adding `true` as the third argument. We might need to typecast the needle for this.

There is one instance in `CalcFunction` where `$oVal` might not be defined. We need to make sure that it is always defined (e.g., as `null`), and handle those cases. This...

There are two places in `DeclarationBlock` where `$oRule` might not be defined. We need to make sure that it is always defined (e.g., as `null`), and handle those cases. This...

Add tests with SimonSapin/css-parsing-tests

1

Let's see whether we can convert the tests from https://github.com/SimonSapin/css-parsing-tests into unit tests.

I propose we mark public methods which are not expected to be used when an application parses CSS and uses the result as `@internal` in order to communicate that these...

Rework the tests

1

I'd like to rework the tests like this (in multiple steps): - [x] #252 change the topmost test namespace from `Sabberworm\CSS` to ` Sabberworm\CSS\Tests` so that tests have their own...

The badge image should be auto-generated by Codacy, display the current coverage of the `master` branch, and link to the full report on Codacy.

I probably would like to split up some methods to better adhere to the single-responsibility principle, and to reduce the number of variables/parameters/return values that mix multiple types. @sabberworm What's...

Add PHP compatibility sniffs

1

As suggested here: https://github.com/sabberworm/PHP-CSS-Parser/pull/218#discussion_r624869280