Oliver Klee

Results 265 comments of Oliver Klee

And (as far as I see) as this isn't necessary for the bugfix (please correct me if I'm wrong) and does not provide any user-/developer facing new feature, I'd prefer...

Battle plan as discussed in our call right now: 1. 8.x We add a `consumeWhiteSpaceWithComments` 2. 8.x `consumeWhiteSpace` redirects to `consumeWhiteSpaceWithComments`, redirect it to the new method and mark it...

@ziegenberg Do we still need this PR now that #671/#672 have been merged?

I propose we move the discussion of the next steps here: #679

Welcome to the project, @calvinrodrigues500! :wave: I've updated the issue description to (hopefully) be more helpful.

@ziegenberg I regret that you didn't get feedback from us on the general direction of this PR. I'm sorry for this. I personally am currently in a conflict in another...

> hope you resolved the disupute/conflict (hope it wasn't with me - if it was, I was unaware :) ) @JakeQZ Well, it's mostly over (though not resolved). And no,...

I regret that it took me so long to give some general feedback on this. So here we go. :-) All classes should use the same logger instance when a...

> Should we be providing a non-null logger in the release package? Shouldn't users be providing a logger of their choice (from a library)? For development/testing, is there some kind...

> I think the `Settings` class can handle this. The logger instance can be added as a property of that. > … > An instance of `ParserState` is passed around...