transformer-time-series-prediction icon indicating copy to clipboard operation
transformer-time-series-prediction copied to clipboard

why multi-step predict future only use one prediction, rather than use the length of output_window like [-output_window:]

Open Jin-Xi opened this issue 3 years ago • 2 comments

https://github.com/oliverguhr/transformer-time-series-prediction/blob/570d39bc0bbd61c823626ec9ca8bb5696c068187/transformer-multistep.py#L210

Jin-Xi avatar Oct 22 '21 04:10 Jin-Xi

Thanks for the report, this is a bug. I just copied the plot code from the single step variant. I guess we need to chnage these two lines, to match the window / step size.

https://github.com/oliverguhr/transformer-time-series-prediction/blob/570d39bc0bbd61c823626ec9ca8bb5696c068187/transformer-multistep.py#L206

https://github.com/oliverguhr/transformer-time-series-prediction/blob/570d39bc0bbd61c823626ec9ca8bb5696c068187/transformer-multistep.py#L210

oliverguhr avatar Oct 24 '21 19:10 oliverguhr

https://github.com/oliverguhr/transformer-time-series-prediction/blob/570d39bc0bbd61c823626ec9ca8bb5696c068187/transformer-multistep.py#L182

I think this line have similar bugs

xiaoerlaigeid avatar Nov 10 '21 03:11 xiaoerlaigeid