Oliver Chang
Oliver Chang
> @oliverchang I'm not sure I like this. I think it's super tailored to catching the last problem (which should be caught through pinning and tests there) and I don't...
@fmeum could you please merge master into this PR to see if that fixes the infra tests?
Thanks @fmeum! @jonathanmetzman WDYT?
Spoke with @jonathanmetzman offline here. The main concern was slowing down CFLite -- we could just gate this behind a flag and let CFLite opt out.
> @oliverchang Some of the checks fail with: > > ``` > 2022-09-09T14:50:01.9843353Z �[0m�[91mERROR: /src/centipede/BUILD:502:8: Compiling blob_file_test.cc failed: (Exit 1): clang-15 failed: error executing command /usr/local/bin/clang-15 -U_FORTIFY_SOURCE -fstack-protector -Wall -Wthread-safety...
This is certainly all doable, but I'm wary of adding very v8 specific logic into our bug filing rules. One alternative may be to include the flags that we used...
> Somewhat unfortunate this PR makes a lot of unrelated changes (like moving the order) Note sure what to do about that, this is just the YAML parser reordering.
CC @jonathanmetzman for review too.
Yes, let's get this in! Sorry for the delay.
> This is similar to #6710 @oliverchang WDYT of this? I think we will probably need to have different images for different platforms if we want to avoid making the...