jimp icon indicating copy to clipboard operation
jimp copied to clipboard

avoid relying on __dirname global constant

Open Javier-Rotelli opened this issue 1 year ago • 2 comments

Fixes #1235

What's Changing and Why

Removed usage of global variable __dirname to avoid errors when bundling with rollup

What else might be affected

Tasks

  • [ ] Add tests
  • [ ] Update Documentation
  • [ ] Update jimp.d.ts
  • [ ] Add SemVer Label

Javier-Rotelli avatar May 18 '23 18:05 Javier-Rotelli

Hey hey @Javier-Rotelli @hipstersmoothie, any plan to get this merged ? 👀 It's really blocking when using Vite…

xavier-villelegier avatar Nov 30 '23 19:11 xavier-villelegier

We would have to make sure it works for all envs, not just modules

hipstersmoothie avatar Feb 22 '24 22:02 hipstersmoothie

Fix in https://github.com/jimp-dev/jimp/pull/1310

hipstersmoothie avatar Sep 02 '24 03:09 hipstersmoothie