olive icon indicating copy to clipboard operation
olive copied to clipboard

Published 20 hours ago • verified publisher icon olive-editor

Add Apply option to preferences dialog

Open p9malino26 opened this issue 2 years ago • 4 comments

I have added an 'Apply' button to the preferences dialog to save the changes without quitting the dialog.

p9malino26 avatar Aug 03 '22 18:08 p9malino26

Is there an actual use-case to wanting to "apply" Olive's preferences dialog?

itsmattkc avatar Oct 08 '22 04:10 itsmattkc

It saves the user from having to repeatedly re-open Preferences to change the same setting if they are trying to trial different settings in order to see what works for them. Appearance is a key example.

p9malino26 avatar Oct 08 '22 08:10 p9malino26

Olive is about to undergo some largish code refactoring and I wanted to check on the status of old PRs before we do that. Do you plan to update/continue with the PR? Thanks

ThomasWilshaw avatar Jan 30 '23 19:01 ThomasWilshaw

It's up to you/the maintainers on whether to merge this pull request. I think this feature is quite useful though.

p9malino26 avatar Feb 01 '23 14:02 p9malino26