8 new styles and "dark" and "light" updates

[pgilfernandez]

Since a while I have been working on Olive styles:

• updating "dark" and "light" ones so that they feel more natural and comfortable when using Olive for a long period of time
• I have updated the styles from "Olive dark" and " Olive light" to just "Dark" and "Light", I think it makes sense
• creating new styles: I'm unsure if all of them should be in master, probably I would drop 2-4 of them, but I wanted to open a discussion about it so I finally added the ones that I feel are the best ones

Following up a quick screenshot of all themes (including actual ones) so that makes it easy to discuss:

Dark (actual)

Dark (updated)

Darker

Grey

Light (actual)

Light (updated)

Olive

Resolve

Seasons - fall

Seasons - spring

Seasons - summer

Seasons - winter

Cheers

[mamarilmanson]

For the summer... just an idea to use this image as a color reference... (or are we imagining different kinds of summer?)

(just an idea...)

:)

[GUY-BBS]

I would suggest a trivial change to Olive's GUI, which I think would significantly improve Olive's appearance. Could the folder icons be buff coloured and the clip icons be changed to thumbnails. I have uploaded two images to show the difference.

[ThomasWilshaw]

Olive is about to undergo some largish code refactoring and I wanted to check on the status of old PRs before we do that. Do you plan to update/continue with the PR? Thanks

[pgilfernandez]

Yes, I do if you are still interested in merging the styles inside Olive

[Simran-B]

I appreciate the effort, but I'm against merging this work into the main repository.

• This PR adds over 50 MB of data, bloating the repo forever. Each CI run has to clone the full repo.
• Committing generated files is a questionable practice. If the changes are infrequent and small in size, it's not that big of a deal, but I would generally avoid it.
• The themes don't add anything functional IMO, in the sense that they merely cater to different tastes but don't add any value in terms of accessibility, for example (high-contrast, Protanopia, Deuteranopia, Tritanopia, ...)

I would rather like to see the theming support to be extended on the code side so that additional themes don't require to compile Olive. Such themes can then be added to a community repo, easily downloaded and installed, without creating a maintenance burden.

[pgilfernandez]

I appreciate the effort, but I'm against merging this work into the main repository.

• This PR adds over 50 MB of data, bloating the repo forever. Each CI run has to clone the full repo.
• Committing generated files is a questionable practice. If the changes are infrequent and small in size, it's not that big of a deal, but I would generally avoid it.

I do agree. BTW, by now it's the only path I can follow in order to add new styles

• The themes don't add anything functional IMO, in the sense that they merely cater to different tastes but don't add any value in terms of accessibility, for example (high-contrast, Protanopia, Deuteranopia, Tritanopia, ...)

Here is where I don't agree (but I understand your position). Themes are what they are but they cover a pretty important aspect of UI-UX: they let customize the look so that users feel comfortable with their software and let them work lots of hours without feeling tired. The fact is that it's impossible to find a perfect theme that suits everybody and therefore the existence of themes... and that's why most (open) software offers the option to change and edit them.

I would rather like to see the theming support to be extended on the code side so that additional themes don't require to compile Olive. Such themes can then be added to a community repo, easily downloaded and installed, without creating a maintenance burden.

And here is where our thoughts meet and the option that solves everything:

• Olive would compile faster, theme independent
• Olive team could officially provide just the themes they find important or necessary
• give users the option to create their owns styles...
• ...without the need to compile Olive

The only "disadvantage" is that, as you said, somebody needs to take care of these code changes. Once finished it would let users load custom themes just by placing the files into a specific folder and Olive on startup would read all of them and let users activate the desired one. I could always be extended with UI components to let users import-export them from Olive Preferences but that's not necessary.

I hope you like the idea and feel like doing the needed code changes. From my side, I can provide these themes and more if you suggest it (for instance high-contrast, Protanopia, Deuteranopia, Tritanopia, ...)

Cheers