olive
olive copied to clipboard
[COLOR] Color manage transitions
Originally opened as https://github.com/sobotka/olive/issues/134
Summary So yeah, transitions (dissolves at least) will have to be managed. While sRGB footage looks fine as-is (presumably because this config maps sRGB 1.0 to scene linear 1.0), anything wider gamut looks like absolute ass.
Additional Information / Output I assume this primarily involves transforming both buffers to a color space of the user's choosing, performing the transition, then bringing them back to reference?
Comment by sobotka
Saturday Jul 18, 2020 at 15:00 GMT
I believe it’s as simple as changing the domain of the curve. That is, manage the curve.
If the curve is in the Filmic Log domain for example, the x axis is input FLEB, and the y output.
How are the curves currently applied in terms of math for input versus output? A link to the code lines would help.
How are the curves currently applied in terms of math for input versus output? A link to the code lines would help. https://github.com/olive-editor/olive/blob/master/app/shaders/crossdissolve.frag https://github.com/olive-editor/olive/blob/master/app/node/block/transition/crossdissolve/crossdissolvetransition.cpp
@sobotka , could you expand a bit what needs to be done here?