tabulator icon indicating copy to clipboard operation
tabulator copied to clipboard

Compress xlsx file

Open RiteshParyali opened this issue 2 years ago • 6 comments

It will compress the File size of XLSX file, I have tried and it compressing more then 50%

RiteshParyali avatar Jul 20 '22 09:07 RiteshParyali

Hey @RiteshParyali

I think this is a great idea!

But i would like to give users the option to disable compression if for whatever reason the dont want to use it. Im happy for it to be on by default as it certainly seems to offer a significant improvement.

Do you think you could update this to look at the compress property of the options object passed into the downloader, and if it is explicitly set to false to then not enable the compression.

Cheers

Oli :)

olifolkerd avatar Jul 24 '22 12:07 olifolkerd

On a completely separate note, @rathboma do you have any idea why the automated checks are showing a fail on this including dist files when it doesn't?

olifolkerd avatar Jul 24 '22 12:07 olifolkerd

By default it's enabled compression.

To disable compression table.download( 'xlsx',FineName.xlsx, { compress: false } )

RiteshParyali avatar Jul 24 '22 12:07 RiteshParyali

It should be false to disable compression

On Sun, 24 Jul 2022, 13:50 Ritesh Paryali, @.***> wrote:

By default it's enabled compression.

To disable compression tableRef.table.download( 'xlsx',FinaName.xlsx, { compress: true } )

— Reply to this email directly, view it on GitHub https://github.com/olifolkerd/tabulator/pull/3868#issuecomment-1193312295, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABUGBTFX2MSIR7NPBPZL7D3VVU32RANCNFSM54C6BPDQ . You are receiving this because you commented.Message ID: @.***>

olifolkerd avatar Jul 24 '22 12:07 olifolkerd

It should be false to disable compression On Sun, 24 Jul 2022, 13:50 Ritesh Paryali, @.> wrote: By default it's enabled compression. To disable compression tableRef.table.download( 'xlsx',FinaName.xlsx, { compress: true } ) — Reply to this email directly, view it on GitHub <#3868 (comment)>, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABUGBTFX2MSIR7NPBPZL7D3VVU32RANCNFSM54C6BPDQ . You are receiving this because you commented.Message ID: @.>

Updated

RiteshParyali avatar Jul 24 '22 12:07 RiteshParyali

Hey @RiteshParyali

thanks for your fast response, i will schedule this for the 5.4 release.

Cheers

Oli :)

olifolkerd avatar Jul 24 '22 13:07 olifolkerd

@RiteshParyali

This has been merged into the 4.0 branch which i am hoping to release by the end of September

Cheers

Oli :)

olifolkerd avatar Sep 04 '22 14:09 olifolkerd