openScale icon indicating copy to clipboard operation
openScale copied to clipboard

Fix #1038 dark mode dialog text color issue

Open crvdgc opened this issue 1 year ago • 2 comments

Fixed two places where the button colors are hard-coded. Also changed AlertDialog's style so that the positive and negative buttons have proper text colors, instead of black.

Closes #1038.

crvdgc avatar May 06 '24 10:05 crvdgc

First of all thx for the PR. On which Android API did you tested it? I tried it with API level 33 and 23 and unfortunately it the text on the birhtday date picker on #1038 is still the same.

oliexdev avatar May 20 '24 09:05 oliexdev

On which Android API did you tested it?

I'm sorry, due to a change of computer, I lost the previous configuration for this project. I think it's automatically picked up by Android Studio, so it's very likely to be the latest one. (Sorry, I'm not very familiar with Android development as well.)

One thing I used to test the PR is to add a manual measurement without creating a user, which triggers this showNoSelectedUserDialog error. Before this PR, the buttons of that dialog in dark mode are black. This PR should at least fix them. Can you test if this is the case? If so, the birthday picker error may be a result of a missing change.

crvdgc avatar May 20 '24 10:05 crvdgc

Thanks, you PR works only for the dialog color. I have finally find a solution to fix every dialog color button problem by only changing the theme xml file, see commit https://github.com/oliexdev/openScale/commit/8b4326687c91d33f496a0f37dc5fc7e14388aca9 But thanks for your effort, your PR gave me the right way.

oliexdev avatar Nov 17 '24 11:11 oliexdev